Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define UserGeo#clear_user_geo. #16004

Merged
merged 1 commit into from Jun 22, 2017
Merged

Define UserGeo#clear_user_geo. #16004

merged 1 commit into from Jun 22, 2017

Conversation

ashercodeorg
Copy link
Contributor

Again, another PR pulling logic from #15210 into the model.

@ashercodeorg ashercodeorg requested a review from Hamms June 21, 2017 18:37
Hamms
Hamms reviewed Jun 22, 2017
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we want to keep state and country?

@ashercodeorg
Copy link
Contributor Author

ashercodeorg commented Jun 22, 2017 •
edited

For reporting reasons (per spec). Presumably, we'll want to be able to say "this many students did CSF / CSD / CSP", being able to include purged accounts.

@ashercodeorg ashercodeorg merged commit 4a7afbe into staging Jun 22, 2017
@ashercodeorg ashercodeorg deleted the clearUserGeo branch June 22, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashercodeorg @Hamms