Hide beta section types #16409
Merged
Hide beta section types #16409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show `google_classroom` (and in the future `clever`) until they are launched.
Bjvanminnen
reviewed
Jul 13, 2017
| @@ -274,7 +274,7 @@ class SectionRow extends Component { | |||
| defaultValue={section.loginType} | |||
| ref={element => this.loginType = element} | |||
| > | |||
| {validLoginTypes.map((type, index) => ( | |||
| {['word', 'picture', 'email'].map((type, index) => ( | |||
There was a problem hiding this comment.
This seems fine as a quick fix. Can we also include a TODO (ideally one mentioning the experiment name, so that when making the experiment permanent it's easy to find/see this).
There was a problem hiding this comment.
Can I add this in JSX as a /* TODO (josh) */ comment?
There was a problem hiding this comment.
FWIW, this flow will change with Brad's work.
There was a problem hiding this comment.
You can add it that way to JSX as long as the /* */ are inside of brace.s
Bjvanminnen
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized we're about to ship
google_classroomas an option in the "New Section" row, even though the functionality is behind a flag:Don't show
google_classroom(and in the futureclever) until they are launched.