Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide beta section types #16409

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Hide beta section types #16409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/src/templates/teacherDashboard/SectionRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ class SectionRow extends Component {
defaultValue={section.loginType}
ref={element => this.loginType = element}
>
{validLoginTypes.map((type, index) => (
{['word', 'picture', 'email'].map((type, index) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine as a quick fix. Can we also include a TODO (ideally one mentioning the experiment name, so that when making the experiment permanent it's easy to find/see this).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add this in JSX as a /* TODO (josh) */ comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this flow will change with Brad's work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add it that way to JSX as long as the /* */ are inside of brace.s

<option key={index} value={type}>{type}</option>
))}
</select>
Expand Down