redirect students to course overview page #17470
Conversation
|
I spoke with @tanyaparker briefly and discussed the redirect that needed to be made in the first place. Apologies to all for the confusion! @ewjordan will this PR work or does any student without an age set have to ONLY go to /home? |
| if current_user.student? && current_user.primary_script && current_user.age.present? | ||
| redirect_to script_next_path(current_user.primary_script) | ||
| if current_user.student? && current_user.primary_script | ||
| redirect_to script_path(current_user.primary_script) |
There was a problem hiding this comment.
We'll have to test this with yesterday's problem scenario for new google classroom students. @ewjordan has the details and knows how to set up a repro. It might be worth still skipping the redirect when age is missing (unless of course we can confirm it works with this new path). If we do remove that check, also remove the associated comment above ;)
There was a problem hiding this comment.
The repro is pretty easy, with a user in the right kind of section to trigger this redirect, from the dashboard-console you can do the same thing the test does:
student.birthday = nil
student.age = nil
student.save(validate: false)
and then just navigate to the root (not home) and make sure that you can enter an age on whatever page you land on.
| get :index | ||
|
|
||
| assert_redirected_to '/home' | ||
| assert_redirected_to script_path(script) |
There was a problem hiding this comment.
like above, verify with @ewjordan that this scenario works and doesn't cause the CSRF error we were seeing yesterday.
|
I believe this should work, though we should definitely verify on staging - the course overview pages do have the CSRF token present, so the age interstitial should work just fine there. Longer term I'm probably also going to set up that interstitial to work on any page so we don't have to worry about this. |
|
WOOO!!! Lots of people are going to be so excited about this. :) |
In #17350 I redirected students with course progress to the next lesson upon sign-in, when I should have redirected them to the course overview page for their top course. Unexpectedly, this caused a bug where students who don't have an age set couldn't access their accounts because they weren't prompted with the age interstitial. Eric tracked down this bug and temporarily fixed it in #17461. (Thank you!!) Long term, we still want all students to land on their course overview page upon sign in.