Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio.code.org: redirect to /home if signed in, otherwise /courses #17500

Merged
merged 2 commits into from Sep 5, 2017

Conversation

breville
Copy link
Member

@breville breville commented Sep 1, 2017

This revisits the changes of #17350 so that, when visiting https://studio.code.org, signed in users are taken to /home, and signed out users are taken to /courses.

This modifies #17350 so that, when visiting https://studio.code.org, signed in users are taken to /home, and signed out users are taken to /courses.
@tanyaparker
Copy link
Contributor

fyi @poorvasingal

@Erin007
Copy link
Contributor

Erin007 commented Sep 1, 2017

Is the change we really want #17470 where students go to the course overview page for their top course?

@tanyaparker
Copy link
Contributor

Yes, we want this change and yours in #17470. This change is a better experience for signed out users (goes to /courses) and teachers (goes to /home). For signed-in students, studio.code.org should still redirect to studio.code.org/home. But, the first time they log in (if they have an assigned course) takes them to their course overview/script page. These two redirects should be independent. So a signed in student going to studio.code.org shouldn't be taking them to their course overview page. That should still be going to /home.

@breville
Copy link
Member Author

breville commented Sep 5, 2017

So this implementation is currently missing this part of the scenario: But, the first time they log in (if they have an assigned course) takes them to their course overview/script page.

Currently we have such functionality for word/picture accounts (using the code at https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/controllers/sections_controller.rb#L31-L34) upon every log in; we'll need to build something similar for all accounts but for first time log in only.

@breville
Copy link
Member Author

breville commented Sep 5, 2017

From talking to @tanyaparker we've decided to merge this in as-is, with more of the above-described work to come later.

@breville breville merged commit 1c539b6 into staging Sep 5, 2017
@breville breville deleted the fix-studio-redirect branch September 5, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants