Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow students under age 13 to view applab and gamelab projects #17579

Merged
merged 8 commits into from
Sep 8, 2017

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 7, 2017

Description

Allow signed-in users under age 13 who do not have a teacher who has agreed to our terms of service agreement to view applab and gamelab projects which do not store data. Also add a few protections against these users creating any applab or gamelab app, or from accessing apps which use data. Also see project work item list doc.

Terminology

in all cases below, students who are under 13 are treated as over 13 if they have a teacher who has accepted the terms of service. A signed-in user who is under 13 and has no teacher (or the teacher has not accepted the terms of service) is "too young". This nomenclature is not great and I'm open to changing it. Alternatives:

  • recompute isSignedIn && !is13Plus && !hasAcceptedTerms in many places and assign them to individual names like canStoreData, canRemix, etc.

  • rename isTooYoung to isYoungWithoutTeacher or something more descriptive.

isTooYoung must remain distinct from is13Plus, because some parts of the product will depend strictly on the user's actual age regardless of whether they have a teacher.

Routing changes

  • signed-in users under 13 can access view and share links for applab projects which do not store data
  • signed-in users under 13 cannot access view and share links for applab projects which do store data (allowed by dashboard, redirected by the client)

Visible changes

A few buttons have been hidden for actions which are not allowed for young students.

before

screen shot 2017-09-06 at 3 48 30 pm

screen shot 2017-09-06 at 3 47 15 pm

after

screen shot 2017-09-06 at 3 48 19 pm

screen shot 2017-09-06 at 3 47 42 pm

There are also a couple of existing warning messages that weren't showing before and are now showing:

too young, with teacher, terms not accepted

screen shot 2017-09-07 at 10 52 17 am

too young, without teacher

screen shot 2017-09-07 at 10 51 16 am

@davidsbailey davidsbailey force-pushed the u13-view-share branch 2 times, most recently from 0cc830c to efc8b61 Compare September 8, 2017 00:07
Copy link
Contributor

@Bjvanminnen Bjvanminnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants