React: Remove uses of React.createClass in publicKeyCryptography #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Sep 8, 2017
There was a problem hiding this comment.
LGTM. Are you using https://github.com/reactjs/react-codemod for this or doing it manually?
|
I'm doing this manually - I don't trust codemod to understand which methods need to be bound, or to use the class property syntax babel extension we've been using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work extracted from #16861 getting us ready to update to React 15.6+.
React.createClassis deprecated, and I'm slowly upgrading our components to ES6 classes.This sixth batch is components within src/publicKeyCryptography.