Add express, pre-express scripts to high scale script list #18536
Conversation
| @@ -31,6 +31,8 @@ def self.scale_mode_scripts | |||
| coursed | |||
| coursee | |||
| coursef | |||
| express | |||
| pre-express | |||
There was a problem hiding this comment.
Is this supposed to include all of our Hour of Code tutorials or did we exclude our high ticket Hour of Code tutorials on purpose?
High traffic tutorials:
mcminecraftflappystarwarsstarwarsblocksfrozenhourofcode
Not so high traffic tutorials that are missing from the list:
gumballsportsbasketballtext-compressionhoc-encryption
There was a problem hiding this comment.
@tanyaparker the other scripts come from a different list, cached_scripts. That list and this one (that I added express and pre-express to) are combined here:
def self.scale_mode_scripts
cached_scripts + %w(
20-hour
course1
...
(https://github.com/code-dot-org/code-dot-org/blob/staging/lib/cdo/script_config.rb#L22)
cached_scripts comes from CACHED_SCRIPTS_MAP here: https://github.com/code-dot-org/code-dot-org/blob/staging/cookbooks/cdo-varnish/libraries/http_cache.rb#L19
That contains all the scripts you were asking about except text-compression and hoc-compression. I suspect because those are not used at high scale during HOC. Since we haven't marked those two as scale scripts in the past I think we're OK on that.
Per @tanyaparker, adding these scripts to our list of high scale scripts for scale mode switches.