Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add express, pre-express scripts to high scale script list #18536

Merged
merged 1 commit into from Oct 20, 2017
Merged

Add express, pre-express scripts to high scale script list #18536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/cdo/script_config.rb
View file
Open in desktop
Expand Up @@ -31,6 +31,8 @@ def self.scale_mode_scripts
coursed
coursee
coursef
express
pre-express
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to include all of our Hour of Code tutorials or did we exclude our high ticket Hour of Code tutorials on purpose?

High traffic tutorials:

  • mc
  • minecraft
  • flappy
  • starwars
  • starwarsblocks
  • frozen
  • hourofcode

Not so high traffic tutorials that are missing from the list:

  • gumball
  • sports
  • basketball
  • text-compression
  • hoc-encryption

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanyaparker the other scripts come from a different list, cached_scripts. That list and this one (that I added express and pre-express to) are combined here:

  def self.scale_mode_scripts
    cached_scripts + %w(
      20-hour
      course1
      ...

(https://github.com/code-dot-org/code-dot-org/blob/staging/lib/cdo/script_config.rb#L22)

cached_scripts comes from CACHED_SCRIPTS_MAP here: https://github.com/code-dot-org/code-dot-org/blob/staging/cookbooks/cdo-varnish/libraries/http_cache.rb#L19

That contains all the scripts you were asking about except text-compression and hoc-compression. I suspect because those are not used at high scale during HOC. Since we haven't marked those two as scale scripts in the past I think we're OK on that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

playlab
artist
infinity
Expand Down