Updated script admin menu #20807
Merged
Updated script admin menu #20807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tessawiedmann
commented
Feb 21, 2018
tessawiedmann
commented
- Removed instructions column
- Added column names
- Added column for template levels
- Added column for contained levels
- Made menu on top of bubbles (z index was too low)
|
Can you confirm that the removed instructions aren't actually being used by anyone? |
Hamms
reviewed
Feb 22, 2018
| .span3 | ||
| = level.properties['project_template_level_name'] | ||
| .span3 | ||
| = level.properties['contained_level_names'] |
There was a problem hiding this comment.
nit; it'd look a lot nicer if you did something like level.properties['contained_level_names'].join(", ")
| .span3 | ||
| = "Template level" | ||
| .span3 | ||
| = "Contained levels" |
|
@Hamms Confirmed by @mrjoshida that instructions aren't used in this menu |
Hamms
approved these changes
Feb 22, 2018
clareconstantine
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.