Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against nil reference bug for levelbuilders in updated script admin menu #20846

Merged
merged 1 commit into from Feb 22, 2018
Merged

Protect against nil reference bug for levelbuilders in updated script admin menu #20846

merged 1 commit into from Feb 22, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Feb 22, 2018

#20807 introduced a nil reference error for levelbuilders that is breaking scripts.

Error https://app.honeybadger.io/projects/3240/faults/36817682:

ActionView::Template::Error: undefined method `join' for nil:NilClass
show.html.haml  91 block (2 levels) in _app_views_scripts_show_html_haml(...)

@aoby aoby added the bug-fix label Feb 22, 2018
@aoby aoby merged commit 552c8be into staging Feb 22, 2018
@aoby aoby deleted the fix-levelbuilder branch February 22, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tessawiedmann tessawiedmann tessawiedmann approved these changes

@clareconstantine clareconstantine Awaiting requested review from clareconstantine

@Hamms Hamms Awaiting requested review from Hamms

Assignees
No one assigned
Labels
bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aoby @tessawiedmann