Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress: fix column width calculations #22059

Merged
merged 1 commit into from Apr 25, 2018
Merged

Progress: fix column width calculations #22059

merged 1 commit into from Apr 25, 2018

Conversation

caleybrock
Copy link
Contributor

@caleybrock caleybrock commented Apr 25, 2018 •
edited

Some of our column widths have been slightly inconsistent - this PR makes them accurate the to the bubbles.

Before examples

screen shot 2018-04-25 at 1 18 54 pm

screen shot 2018-04-25 at 1 19 12 pm

screen shot 2018-04-25 at 1 19 36 pm

screen shot 2018-04-25 at 1 19 55 pm

After examples

screen shot 2018-04-25 at 1 15 58 pm

screen shot 2018-04-25 at 1 16 13 pm

screen shot 2018-04-25 at 1 16 30 pm

screen shot 2018-04-25 at 1 16 46 pm

@caleybrock caleybrock merged commit 2ac73fc into staging Apr 25, 2018
@caleybrock caleybrock deleted the width-adjustments branch April 25, 2018 21:38
@caleybrock caleybrock mentioned this pull request Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddiedierker maddiedierker maddiedierker approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
teacher-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caleybrock @maddiedierker @Erin007