Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress: don't show arrows when columns are too small #22065

Merged
merged 1 commit into from Apr 25, 2018
Merged

Progress: don't show arrows when columns are too small #22065

merged 1 commit into from Apr 25, 2018

Conversation

caleybrock
Copy link
Contributor

This fix should have been included in #22059

Now that we've adjusted the bubble width constants and used margins, include that in the max width calculation.

Result:
screen shot 2018-04-25 at 2 54 37 pm

@caleybrock caleybrock requested a review from Erin007 April 25, 2018 21:56
@caleybrock caleybrock merged commit 341ec3c into staging Apr 25, 2018
@caleybrock caleybrock deleted the fix-diamond-widths branch April 25, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
teacher-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caleybrock @Erin007