Remix - add null check #22077
Merged
Remix - add null check #22077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
commented
Apr 26, 2018
| @@ -99,7 +99,7 @@ def remix_source(src_channel, dest_channel, animation_list) | |||
| anim_response = animation_list.find do |item| | |||
| item[:filename] == "#{a['key']}.png" | |||
| end | |||
| src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty? | |||
| src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty? || anim_response.nil? | |||
There was a problem hiding this comment.
@islemaster There seems to be conflicting opinions on dev blogs about having multiple arguments in 'unless', do we have a preference at Code.org?
There was a problem hiding this comment.
I think we're fine with complex inline conditionals, if that's what you're asking. As long as you feel it reads sufficiently well.
islemaster
approved these changes
Apr 26, 2018
| @@ -99,7 +99,7 @@ def remix_source(src_channel, dest_channel, animation_list) | |||
| anim_response = animation_list.find do |item| | |||
| item[:filename] == "#{a['key']}.png" | |||
| end | |||
| src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty? | |||
| src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty? || anim_response.nil? | |||
There was a problem hiding this comment.
Reversing the order of these checks would make the safe-navigation operator unnecessary.
... unless anim_response.nil? || anim_response.empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the continuation of this honeybadger error: https://app.honeybadger.io/projects/3240/faults/37524712#notice-trace
Null animation_responses were passing this check: 'anim_response&.empty?' when we would like to to fail there. Adding a nil? check resolves the problem.