Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remix - add null check #22077

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Remix - add null check #22077

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b38e738
Add additional null check
Apr 26, 2018
ca07f7d
Syntax improvements
Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/middleware/helpers/source_bucket.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def remix_source(src_channel, dest_channel, animation_list)
anim_response = animation_list.find do |item|
item[:filename] == "#{a['key']}.png"
end
src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty?
src_body.set_animation_version(a['key'], anim_response[:versionId]) unless anim_response&.empty? || anim_response.nil?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@islemaster There seems to be conflicting opinions on dev blogs about having multiple arguments in 'unless', do we have a preference at Code.org?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're fine with complex inline conditionals, if that's what you're asking. As long as you feel it reads sufficiently well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversing the order of these checks would make the safe-navigation operator unnecessary.

... unless anim_response.nil? || anim_response.empty?

end
end

Expand Down