DTL (Test > Levelbuilder): 873b14dd #22169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r enables sharing
The level data we've been uploading to crowdin has two issues.
First, the yaml system we've been using wraps content like:
en:
data:
instructions:
2-3 Artist 1 new_instruction: "Hi, I'm an artist. You can write code to make
me draw almost anything. Use a few blocks to make me draw over the grey lines
in the picture. (Each line is 100 pixels long)"
This is not a valid way to do multiline strings in yaml. Although there
certainly exist ways to do multiline strings in yaml with the goal of
keeping yaml as a human-editable serialization format, we don't really
care about human-editability for this data and so are now going to
serialize the data like:
en:
data:
instructions:
2-3 Artist 1 new_instruction: "Hi, I'm an artist. You can write code to make me draw almost anything. Use a few blocks to make me draw over the grey lines in the picture. (Each line is 100 pixels long)"
Second, our data includes carriage returns (`\r`) as well as newlines
(`\n`). This should be fine, but crowdin does not render carriage
returns correctly, instead just rendering them as plaintext. This
results in translators seeing content that looks like
My snowflake is falling apart!\r
\r
Can you figure out what's going wrong?
To fix this, we just strip out all carriage returns, replacing them with
newlines as appropriate
…blocks-when-used Only fail empty function blocks if there's a corresponding call block
DTT (Staging > Test) [robo-dtt]
special i18n sync to capture newlines changes
Fix newline crowdin issues
DTT (Staging > Test) [robo-dtt]
DTT (Staging > Test) [robo-dtt]
Cache requests on teacher dashboard
DTT (Staging > Test) [robo-dtt]
Adjust project sharing privileges
DTT (Staging > Test) [robo-dtt]
Survey Question table
DTT (Staging > Test) [eric]
…org/code-dot-org into completed-levels-count
…org/code-dot-org into completed-levels-count
…s branch are being made
…org/code-dot-org into completed-levels-count
Stats tab: disable completed level count
DTT (Staging > Test) [robo-dtt]
Separate completed_levels_count as a new endpoint in dashboard API
Rewrite teacher dashboard "stats" tab in react using newly-created `completed_levels_count` endpoint in dashboardapi
Stats tab: add new line to file
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.