Update /v2/sections/valid_scripts dependencies
#22669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,7 +115,7 @@ def valid_scripts | |||
| return head :forbidden unless current_user | |||
|
|
|||
| scripts = Script.valid_scripts(current_user).map(&:assignable_info) | |||
| render json: {scripts: scripts} | |||
| render json: scripts | |||
There was a problem hiding this comment.
please double check that all of your integers in this json are coming back as integers and not strings. for some reason, I ran into a problem when rendering an array as json (like you have it here), rather than rendering an object (like it was before). past discussion for a bit of context: #22176 (comment)
There was a problem hiding this comment.
thank you for the heads up! i double checked my response and the integers look good (image from the frontend below), but i'll keep an eye out for any weirdness with that
davidsbailey
approved these changes
May 24, 2018
islemaster
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the work to move the
/v2/sections/valid_scriptsendpoint to dashboard. See #22507 and #22655 for more context.What it does
teacherSectionsRedux(including tests and storybook dependencies) to the new endpoint atdashboardapi/sections/valid_scriptsscriptsrather than nested{scripts: scripts}JSON for more straightforward consumption on the frontendFollow-up Work
/v2/sections/valid_scriptsand log a notification to Honeybadger once all known dependencies have been removed