Bug fix: valid scripts with no alternate script mapped to nil for experiment-enabled users #22687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or experiment-enabled users
caleybrock
approved these changes
May 25, 2018
islemaster
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug found in this Honeybadger error and a failing feature test on related PR #22669. For users with course experiments enabled,
Script.valid_scriptsreturnednilfor any script that did not have an alternate script.Rather than just mapping scripts to their alternate scripts for course-experiment-enabled users,
valid_scriptsshould check if an alternate script exists. If there is an alternate script, return the alternate; otherwise, return the original script (rather thannil).