loopHighlight doesn't have any loop protection

[joshlory]

Follow up to PR #22463. That PR fixed Artist puzzles (example) but @jmschulte found that Maze puzzles (example) could still infinitely loop.

It looks like Maze used Maze.loopHighlight(%1); which doesn't actually protect against infinite loops. Changed to use the loop trap instead.

[Hamms]

What was the purpose of loopHighlight? Can it be removed?

[joshlory]

It's still used by the maze_forever block:

code-dot-org/apps/src/maze/blocks.js

Line 379 in d720692

branch = codegen.loopTrap() + codegen.loopHighlight('Maze', this.id) + branch;