Re-merge maze loop trap #22970
Merged
Re-merge maze loop trap #22970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Jun 7, 2018
| @@ -764,3 +764,7 @@ export function calculateOffsetCoordinates(element, clientX, clientY) { | |||
| y: Math.round((clientY - rect.top) * element.offsetHeight / rect.height), | |||
| }; | |||
| } | |||
|
|
|||
| export function escapeRegExp(str) { | |||
| return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"); | |||
There was a problem hiding this comment.
Huh, do special characters not need to be escaped when in a character set?
joshlory
force-pushed
the
remerge-maze-loop-trap
branch
from
0b041c5
to
2615d1e
Compare
joshlory
force-pushed
the
remerge-maze-loop-trap
branch
from
1b4b803
to
7e7970f
Compare
joshlory
commented
Nov 13, 2019
| @@ -48,7 +48,7 @@ exports.strip = function (code) { | |||
| // Strip out serial numbers. | |||
| .replace(/(,\s*)?'block_id_\d+'\)/g, ')') | |||
| // Remove timeouts. | |||
| .replace(INFINITE_LOOP_TRAP, '') | |||
| .replace(new RegExp(utils.escapeRegExp(INFINITE_LOOP_TRAP), 'g'), '') | |||
There was a problem hiding this comment.
Coming soon to babel, replaceAll for this exact use case! https://twitter.com/v8js/status/1193917549060280320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert PR #22860, to re-merge PR #22752 (with fixes).