New student deletion flow #23651
Merged
New student deletion flow #23651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Jul 11, 2018
| if (experiments.isEnabled(experiments.ACCOUNT_DELETION_NEW_FLOW)) { | ||
| const deleteAccountMountPoint = document.getElementById('delete-account'); | ||
| // Replace deleteAccountMountPoint Rails contents with DeleteAccount component. | ||
| ReactDOM.render( |
There was a problem hiding this comment.
I think this needs to check if the mount point actually exists - it's possible it won't be rendered if the user doesn't have permission to delete their own account.
There was a problem hiding this comment.
you're right! i'll add that check.
| @@ -177,16 +177,20 @@ | |||
| %span#change-user-type-status | |||
| %button.btn#change-user-type-button{disabled: true}= t('signup_form.user_type_button') | |||
|
|
|||
| %hr.danger.account-page-section-break | |||
| %h2.danger= t('user.delete') | |||
There was a problem hiding this comment.
Do we no longer show the horizontal rule and header for the Delete Account section in the case where the user cannot delete their own account?
There was a problem hiding this comment.
😱 thanks for catching that! i think i resolved a merge conflict incorrectly. i'll add that back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New UI flow for student account deletion (spec).
After successfully submitting, the user is logged out and routed to "/".
Examples
When submitted with the wrong password:
On an unexpected error:
Follow-up Work