New teacher account deletion flow #23666
Conversation
| "deleteAccount_teacherWarning3": "that don’t have a personal login or aren’t in another teacher’s section. Please make sure you have the authority to delete these students’ education records before deleting your own account. ", | ||
| "deleteAccount_teacherWarning4": "Give these students a chance to keep using their Code.org accounts by ", | ||
| "deleteAccount_teacherWarning5": "sending home instructions for creating personal logins. ", | ||
| "deleteAccount_teacherWarning6": "Give them at least a few days to follow these instructions BEFORE you delete your account.", |
There was a problem hiding this comment.
@Hamms Sorry to bug you, but what would it take for us to get redacted markdown working for apps translations like this? We've been seeing this more and more in accounts/teacher dashboard tools, and are really looking forward to markdown support.
There was a problem hiding this comment.
No worries! To clarify, do we actually need redacted markdown support or just markdown support?
There was a problem hiding this comment.
i think both in this case. most of the text just requires styling, but there are a few that are links that would need to be redacted
There was a problem hiding this comment.
Translated markdown, which I assumed (for security reasons) meant we needed redacted markdown.
There was a problem hiding this comment.
Ah, looking closer at what you're doing here, it seems like the answer is "both".
I would, however, say they are two separate issues. Implementing redacted markdown will make sending stuff that contains things like URLs or other immutable/sensitive information off to translators safe and easy, but we will still need a way to render that markdown in an apps context
| allCheckboxesChecked = () => { | ||
| const {checkboxes} = this.state; | ||
| const uncheckedBoxes = _.filter(Object.keys(checkboxes), id => !checkboxes[id].checked); | ||
| return uncheckedBoxes.length === 0; |
There was a problem hiding this comment.
const {checkboxes} = this.state;
return Object.keys(checkboxes).every(id => checkboxes[id].checked);| {i18n.deleteAccount_teacherWarning6()} | ||
| </p> | ||
| </div> | ||
| } | ||
| </div> |
There was a problem hiding this comment.
This might be a good candidate for extraction to helper components in this file; It's be nice to write
{this.props.isTeacher ? <TeacherWarning/> : <StudentWarning/>}and then hide the i18n/formatting mess away.
There was a problem hiding this comment.
good idea! i'll make that refactor
This is follow-up for #23651 and updates the account deletion confirmation modal for teachers (spec).
Before
After
Remaining Work