Projects: projectValidator prop -> limitedGallery prop #24650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Sep 5, 2018
| // Due to risk of inappropriate content, we can hide non-featured Applab | ||
| // and Gamelab projects via DCDO. Internally, project_validators should | ||
| // always have access to all Applab and Gamelab projects, even if there is a // limited gallery for others. | ||
| - limited_project_gallery = DCDO.get('image_moderation', {})['limited_project_gallery'] |
There was a problem hiding this comment.
Can we reuse or remove the helper we already wrote for this?
code-dot-org/lib/cdo/azure_content_moderator.rb
Lines 172 to 176 in c9ff823
We may need to make it a static method. If you decide to remove that one and do this inline, let's make sure we capture the "true by default" behavior.
It might also be nice to make limited_gallery? a helper in projects_controller.rb and call that here instead of bothering with DCDO and UserPermission right here in the view.
| // always have access to all Applab and Gamelab projects, even if there is a // limited gallery for others. | ||
| - limited_project_gallery = DCDO.get('image_moderation', {})['limited_project_gallery'] | ||
| - project_validator = current_user.permission? UserPermission::PROJECT_VALIDATOR | ||
| - projects_data[:limitedGallery] = project_validator ? !project_validator : limited_project_gallery |
There was a problem hiding this comment.
project_validator ? !project_validator : limited_project_gallerysimplifies to
!project_validator && limited_project_gallery
|
@islemaster What do you think about the updates? Any other requested changes? |
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #24643
This PR uses the new DCDO parameter for
limited_galleryto determine whether to hide or show the view more links for App Lab and Game Lab in the public project gallery. Previously, the decision to show/hide the view more link was based solely on whether the user has project validator permissions. Now a new prop,limitedGalleryis set based on both the DCDO parameter and whether the user has project validator permissions. If the user is a project validator, they always have access to the view more links. If they are not, the links are shown based on the value forlimited_galleryset via DCDO.