New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unhide script and warn when assigning it from the script overview page #24684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Well-tested.
dashboard/app/models/script.rb
Outdated
@@ -1111,6 +1112,18 @@ def summarize(include_stages = true, user = nil) | |||
summary | |||
end | |||
|
|||
# @return {Hash<string,number[]>|number[]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the last bit of this type signature is wrong; just {Hash<string,number[]>}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! copy-pasta.
Background
Spec line item: https://docs.google.com/document/d/17X2bEVK4YO4gymmVEzAnDYCYTjE5xHQTlDSAZbEprTo/edit#bookmark=id.hko4b4h5at6x
Terminology
The term "hidden script" is ambiguous. This PR talks about hiding scripts for certain sections as determined by the
SectionHiddenScript
model, which a teacher controls by that script's course's CourseOverview page. No part of this PR has anything to do with thehidden
property on theScript
model, which is controlled via the levelbuilder UI.Description
Future work
Screenshots