Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show hidden unit warning banner on script overview page #24695

Merged
merged 4 commits into from Sep 10, 2018

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 10, 2018

Background

Spec line item: https://docs.google.com/document/d/17X2bEVK4YO4gymmVEzAnDYCYTjE5xHQTlDSAZbEprTo/edit#bookmark=id.v0i89kcbrl7r

Description

Show a warning banner on the script overview page if the script is a unit of a course which is hidden for the currently selected section in the SectionSelector. This builds on #24684 and #24682

Screenshot

screen shot 2018-09-10 at 10 32 42 am

@davidsbailey davidsbailey changed the base branch from unhide-assigned-script to staging September 10, 2018 17:50
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the UI test!

@davidsbailey davidsbailey merged commit df88791 into staging Sep 10, 2018
@davidsbailey davidsbailey deleted the hidden-unit-banner branch September 10, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants