Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Send Regional Partner Emails from allowed address #25233

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

islemaster
Copy link
Contributor

@aoby explained this:

We have a list of allowed senders here (https://github.com/code-dot-org/code-dot-org/blob/staging/lib/cdo/poste.rb#L269), though usually we send from one of the existing ones, e.g. teacher@ with an actual person's name

For example: https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/mailers/pd/application/teacher1920_application_mailer.rb#L52
So you can either change to from: 'Anthonette Peña <teacher@code.org>', or add her email to the allowed senders in poste

Making this change immediately to fix the broken form, while I revisit this with stakeholders to see what behavior they actually need and finding a way to reliably cover this with automated tests.

@islemaster
Copy link
Contributor Author

Doing some manual local testing (without mailcatcher) and hoping to let Circle at least get past the build step...

@islemaster
Copy link
Contributor Author

I assume this development.log output is what I expect to see in the success case?

Pd::RegionalPartnerContactMailer#matched: processed outbound mail in 24.3ms
Sent mail to teacher_596@code.org (21.3ms)
Date: Thu, 04 Oct 2018 10:41:02 -0700
From: =?UTF-8?B?QW50aG9uZXR0ZSBQZcOxYQ==?= <teacher@code.org>
To: teacher_596@code.org

@islemaster
Copy link
Contributor Author

This article sheds some light on =?UTF-8?B?QW50aG9uZXR0ZSBQZcOxYQ==?=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants