Send RegionalPartnerContact email from partner@ (and tests!) #25238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Oct 4, 2018
aoby
reviewed
Oct 4, 2018
| # includes some additional constraints, like a limited set of allowed senders. | ||
| # | ||
| # @param [Mail::Message] mail as returned by an ActionMailer::Base's mail() method | ||
| def assert_sendable(mail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week we made several changes to the Regional Partner Contact Form and associated emails. These changes included a bug that caused email sending to fail due to the from address not being on an allow list in our Poste module. We hotfixed here to send from
teacher@code.orginstead to get things working as quickly as possible.Now, stakeholders have let us know they'd rather have this mail come from
partner@code.orgwhich is not currently on the allow list. I've added it to the allow list, and workout out how to add an assertion to our tests that actually runs the Poste logic with its additional checks, to verify that the mail is sendable.