Dance party: Don't allow song to be changed while running #25932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dance party has a kind of pre-run state in which the user has pressed Run, but it's still loading assets, and so we need to disable the song selection during that state too.
breville
requested review from
joshlory,
Bjvanminnen,
epeach and
davidsbailey
…-running Conflicts: apps/src/dance/Dance.js
Bjvanminnen
reviewed
Nov 8, 2018
apps/src/dance/Dance.js
Outdated
| @@ -395,6 +397,7 @@ Dance.prototype.runButtonClick = async function () { | |||
| this.studioApp_.toggleRunReset('reset'); | |||
| // Safe to allow normal run/reset behavior now | |||
| this.runIsStarting = false; | |||
| getStore().dispatch(setRunIsStarting(false)); | |||
There was a problem hiding this comment.
do we still need this.runIsStarting?
There was a problem hiding this comment.
Ah, I can use redux now. Good idea.
Bjvanminnen
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
I downloaded the branch to check things out. It looks like the song dropdown is disabled the entire time the song is running, which seems reasonable but was not my understanding from the PR description?
Code changes LGTM, but should probably come with a short test.
|
Oh, the description is an extra detail in addition to the title. I'll update :) |
|
+1 for adding a short regression test! |
davidsbailey
approved these changes
Nov 8, 2018
|
UI test coverage added. |
breville
deleted the
dance-party-fix-song-can-be-changed-while-running
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables changing song while the dance party level is running.
Dance party has a kind of pre-run state in which the user has pressed Run, but it's still loading assets, and so we disable the song selection during that state too.
Fixes code-dot-org/dance-party#190.