Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dance party: Don't allow song to be changed while running #25932

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Dance party: Don't allow song to be changed while running #25932

merged 4 commits into from
Nov 9, 2018

Commits on Nov 8, 2018

  1. Dance party: Don't allow song to be changed while running 

    Dance party has a kind of pre-run state in which the user has pressed Run, but it's still loading assets, and so we need to disable the song selection during that state too.
    @breville
    breville committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    020c0ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'staging' into dance-party-fix-song-can-be-changed-while… 

    …-running

Conflicts:
	apps/src/dance/Dance.js
    @breville
    breville committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    9c6fe44 View commit details
    Browse the repository at this point in the history

  3. Dance party: use redux state instead of redundant variable

    @breville
    breville committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    d89d264 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Dance party: UI test for song selector being disabled when running

    @breville
    breville committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    99cf67f View commit details
    Browse the repository at this point in the history