Fit reg 1920 code #26276
Fit reg 1920 code #26276
Conversation
clareconstantine
changed the base branch from
fit-reg-1920-migration
to
staging-next
| photoRelease: [YES], | ||
| liabilityWaiver: [YES], | ||
| }.freeze | ||
| end |
There was a problem hiding this comment.
A lot of the content in here seems potentially year-specific; what's the long-term goal here?
There was a problem hiding this comment.
I think much of what is in here will be relevant in future years, so I am erring on the side of starting with it in the base class and in future years we can move pieces that aren't being shared into year-specific classes, rather than pulling shared pieces back up into the parent from the year-specific classes.
| return | ||
| end | ||
|
|
||
| super |
There was a problem hiding this comment.
There isn't really a super class to invoke here. This should be removed. If there are fields that we'll always want, they should be here. Otherwise this should be a method that expects a derived class to override and throws an exception if it doesn't
There was a problem hiding this comment.
now this just calls the super class (Pd::Form)'s method. Derived classes can add additional validations.
(merge after #26265)
FitWeekend1920RegistrationandFitWeekendRegistrationBasemodels