Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fit registration mailer not to be year-specific #26281

Merged
merged 2 commits into from Dec 14, 2018

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented Nov 30, 2018

(merge after #26276)

This mailer doesn't need to know what year it is, and this will save us having to update it every year.

Copy link
Contributor

@mehalshah mehalshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test somewhere that invokes this mailer?

@clareconstantine
Copy link
Author

@clareconstantine
Copy link
Author

@mehalshah there isn't currently a test, just the mail previews and their test, which iterates over all previews and doesn't refer to mailers by class name.

@clareconstantine clareconstantine changed the base branch from fit-reg-1920-code to staging December 14, 2018 19:38
@clareconstantine clareconstantine merged commit a5bc0fc into staging Dec 14, 2018
@clareconstantine clareconstantine deleted the fit-reg-1920-mailer branch December 19, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants