PL: teacher application form improvements #27011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the teacher application uses the PAGE_LABELS as helpers to get label strings, the details view used to view the application relies on PAGE_LABELS as the source of truth for which questions to show in which sections and in which order. As a way to preserve that source of truth, we can borrow a technique in which the client pulls across the label strings from another section.
clareconstantine
approved these changes
Feb 13, 2019
| <ul> | ||
| <li> | ||
| <span style={styles.bold}>Section 1: About you</span> | ||
| (Your and your principal’s contact info) |
There was a problem hiding this comment.
It looks like the principal's contact info is now in section 2
There was a problem hiding this comment.
Great catch. I missed this change in the spec.
breville
commented
Feb 13, 2019
| Section3TeachingBackground, | ||
| Section2ChooseYourProgram, |
There was a problem hiding this comment.
Note that I chose to not rename the classes & files for these, despite switching their order, just to reduce churn on the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
section 1
section 2
section 3
thanks
After
section 1
section 1 - nominated
section 2
section 3
thanks