Rename teacher app sections #31039
Rename teacher app sections #31039
Conversation
clareconstantine
changed the base branch from
staging
to
principal-approval-2021
There was a problem hiding this comment.
Thanks for doing this!
A lesson I learned when doing Hour of Code tutorials long ago was that if you have a lot of sections/levels that have both a name and an index in the name, get rid of the index and just refer to them by name, and then you never have to worry about changing the order.
That aside, this fix feels appropriate and good!
I was considering that - do you think I should remove the indices? they are helpful until we need to change them :P |
|
@clareconstantine If you were already considering it, then it sounds like it might be worth doing. It's not egregious in this case, but as a matter of principle I think it's a good one :) |
@breville I took out the indexes entirely! |
clareconstantine
changed the base branch from
principal-approval-2021
to
staging
| @@ -49,7 +49,11 @@ def self.clean_multiline(string) | |||
| how_heard: 'How did you hear about this program?' | |||
| } | |||
| ), | |||
| section_2_choose_your_program: { | |||
| teaching_background: | |||
| BASE_PAGE_LABELS[:section_2_your_school].slice( | |||
There was a problem hiding this comment.
Ah, so we have some mentions of section_X further upstream? It's fine to keep this change constrained but also interested to ponder how far we can take the numberless principle :)
There was a problem hiding this comment.
I agree! I'm going to fix that as part of an upcoming change to simplify how our constants files are structured.
| about_you: 'About You', | ||
| teaching_background: 'Teaching Background', | ||
| choose_your_program: 'Choose Your Program', | ||
| professional_learning_program_requirements: 'Professional Learning Program Requirements', | ||
| additional_demographic_information: 'Additional Demographic Information and submission', |
There was a problem hiding this comment.
This feels good.. the ordering feels less hardcoded now, and more flexible to change order if we discover that we should!
Description
Rename teacher application sections so the section numbers reflect the actual order in which they appear in the application, following up to this change made last year that flipped the Teaching Background and Choose Your Program sections.
Jira task