Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused showInstructionsDialog prop from TopInstructionsCSF #27750

Merged
merged 1 commit into from Apr 1, 2019
Merged

remove unused showInstructionsDialog prop from TopInstructionsCSF #27750

merged 1 commit into from Apr 1, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 28, 2019 •
edited

We used to use this to display authored hints, before the top instructions refactor that turned everything into chat bubbles.

@Hamms Hamms requested a review from epeach March 28, 2019 19:34
epeach
epeach approved these changes Apr 1, 2019
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Nice clean-up!

@Hamms Hamms merged commit 3d67655 into staging Apr 1, 2019
@Hamms Hamms deleted the remove-unused-showInstructionsDialog branch April 1, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeach epeach epeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @epeach