Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused showInstructionsDialog prop from TopInstructionsCSF #27750

Merged
merged 1 commit into from
Apr 1, 2019
Merged

remove unused showInstructionsDialog prop from TopInstructionsCSF #27750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 1 addition & 12 deletions apps/src/templates/instructions/TopInstructionsCSF.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import Radium from 'radium';
import classNames from 'classnames';
import {connect} from 'react-redux';
var instructions = require('../../redux/instructions');
import {openDialog} from '../../redux/instructionsDialog';
var color = require('../../util/color');
var styleConstants = require('../../styleConstants');
var commonStyles = require('../../commonStyles');
Expand Down Expand Up @@ -224,8 +223,7 @@ class TopInstructions extends React.Component {
toggleInstructionsCollapsed: PropTypes.func.isRequired,
setInstructionsHeight: PropTypes.func.isRequired,
setInstructionsRenderedHeight: PropTypes.func.isRequired,
setInstructionsMaxHeightNeeded: PropTypes.func.isRequired,
showInstructionsDialog: PropTypes.func.isRequired
setInstructionsMaxHeightNeeded: PropTypes.func.isRequired
};

static defaultProps = {
Expand Down Expand Up @@ -888,15 +886,6 @@ module.exports = connect(
},
clearFeedback(height) {
dispatch(instructions.setFeedback(null));
},
showInstructionsDialog(height) {
dispatch(
openDialog({
autoClose: false,
imgOnly: false,
hintsOnly: true
})
);
}
};
},
Expand Down