Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Questions in Assessments Tab: Add to submission status table and download csv #28343

Merged
merged 6 commits into from May 6, 2019

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented May 3, 2019

We recently made it so match questions could be included in LevelGroup assessments but we did not show the results to teachers in the assessment tab.

This is step 1 of showing the results to teachers in the assessment tab. It shows the total number of match questions and the total number of match questions they got right for an assessment. It also includes those numbers in the CSV download. Note: the total number of match questions is calculated by the number of options for each match question added together. So for example if there are 2 match questions one with 4 options and one with 3 options. We would have 7 total "match questions" and the students number correct would be based on the number of those matches they got right.

Submission Status Table

Test with Match Questions

Screen Shot 2019-05-03 at 10 38 44 AM

Test without Match Questions

Screen Shot 2019-05-03 at 10 40 44 AM

CSV Download

Screen Shot 2019-05-03 at 10 39 03 AM

numMultipleChoiceCorrect: TABLE_WIDTH / 12,
numMultipleChoice: TABLE_WIDTH / 12,
numMatchCorrect: TABLE_WIDTH / 12,
numMatch: TABLE_WIDTH / 12,
submissionTimeStamp: TABLE_WIDTH / 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some weird math. neither before nor after add up to 100% of TABLE_WIDTH:

irb(main):001:0> 1.0/3 + 3.0/8 + 1.0/5
=> 0.9083333333333332
irb(main):002:0> 1.0/3 + 4.0/12 + 1.0/5
=> 0.8666666666666667

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as long as it looks ok, and the total table width isn't weirdly different from any other tables on the page, it should be fine though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it so it makes more sense but it still seems to be working the same 🤷‍♀

@Erin007
Copy link
Contributor

Erin007 commented May 3, 2019

Not a problem to solve here, but it seems strange to me that we use valuable table space for an entire column of how many multiple choice questions there are. Why not one multiple choice column with a fraction of how many correct out of how many total?

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions throughout for my own understanding, but this is lookin' good!

@dmcavoy dmcavoy merged commit bf60f1e into staging May 6, 2019
@dmcavoy dmcavoy deleted the match-question-assessment-tab-part-1 branch May 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants