Match Questions in Assessments Tab: Add Overview of class responses by question #28345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
changed the base branch from
staging
to
match-question-assessment-tab-part-2
Erin007
reviewed
May 3, 2019
apps/src/templates/sectionAssessments/MatchAssessmentsOverviewContainer.jsx
Show resolved
Hide resolved
Erin007
reviewed
May 3, 2019
apps/src/templates/sectionAssessments/MatchAssessmentsOverviewTable.jsx
Outdated
Show resolved
Hide resolved
Erin007
reviewed
May 3, 2019
apps/src/templates/sectionAssessments/MatchAssessmentsOverviewTable.jsx
Outdated
Show resolved
Hide resolved
Erin007
reviewed
May 3, 2019
apps/src/templates/sectionAssessments/MatchAssessmentsOverviewTable.story.jsx
Show resolved
Hide resolved
Erin007
reviewed
May 3, 2019
Erin007
reviewed
May 3, 2019
Erin007
reviewed
May 3, 2019
| @@ -104,7 +106,8 @@ class SectionAssessments extends Component { | |||
|
|
|||
| state = { | |||
| freeResponseDetailDialogOpen: false, | |||
| multipleChoiceDetailDialogOpen: false | |||
| multipleChoiceDetailDialogOpen: false, | |||
| matchDetailDialogOpen: false | |||
There was a problem hiding this comment.
Is there ever a scenario where these two dialogs are trying to be open at the same time?
There was a problem hiding this comment.
I don't think so. these open when you click on the see more for the question
Erin007
reviewed
May 3, 2019
apps/test/unit/templates/sectionAssessments/sectionAssessmentsReduxTest.js
Show resolved
Hide resolved
Erin007
reviewed
May 3, 2019
apps/test/unit/templates/sectionAssessments/sectionAssessmentsReduxTest.js
Outdated
Show resolved
Hide resolved
Erin007
approved these changes
May 3, 2019
…on-assessment-tab-part-3
…on-assessment-tab-part-3
dmcavoy
changed the base branch from
match-question-assessment-tab-part-2
to
staging
davidsbailey
approved these changes
May 7, 2019
| import { | ||
| matchQuestionWith2Pairs, | ||
| matchQuestionWith4Pairs | ||
| } from './assessmentsTestHelpers'; |
There was a problem hiding this comment.
this is a good example a test fixture, which we are trying to move toward using more often. thanks for adding this!
| @@ -0,0 +1,107 @@ | |||
| /* eslint-disable react/no-danger */ | |||
There was a problem hiding this comment.
this doesn't look needed. remove from here, plus wherever you copied it from?
There was a problem hiding this comment.
Will do! Going to fix on the part 4 branch and ship this PR
| @@ -29,7 +29,7 @@ function calculateOpacity(answered) { | |||
| return (answered + 10) / 100; | |||
| } | |||
|
|
|||
| class MultipleChoiceAnswerCell extends Component { | |||
| class PercentAnsweredCell extends Component { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 3 of Match Questions in Assessment Tab.
Part 1: #28343
Part 2: #28344
This adds a section with tables for each match question that breaks down how the class answered that question.
If you click on the "...see full question" you can view the whole question and the answers in a dialog window.
Hovering over a column header will show you the full text in a tooltip.