Fixed toolbox overlay issue in spritelab.

[jmkulwik]

Spritelab top instructions had a bug where the instruction space would resize when switching between code and animation mode. This bug had always existed, but was not exercised until animation mode was added. The issue was not visibly recognized because resize events were being called extra times. In project mode, however, the resize events were causing rendering problems with the toolbox. This PR removes the extra resize events and resizes the instruction space only when needed.

Note: The red text difference in the 'instruction resize' gifs is due to a known issue in staging. Not due to this change.

Manual sanity checks performed:

• dancelab is unchanged
• gamelab is unchanged
• hints still render as expected
• expand/collapse still works as expected

OLD instruction resize:

NEW instruction resize:

OLD toolbox rendering:

NEW toolbox rendering:

[epeach]

This looks similar to the change that was reverted which caused the toolbox to not render. Do you know what caused that regression and how this PR won't protects against that?

[jmkulwik]

This looks similar to the change that was reverted which caused the toolbox to not render. Do you know what caused that regression and how this PR won't protects against that?

Yes. The previous PR which ended up causing a regression (#28294) was caused by a circular dependency.

Window.resize, which was called by Gamelab/actions.changeInterfaceMode was what caused the blockly blocks to appear under the toolbox. In a level that was part of a progression, however, changing to design mode also caused the instruction section of the screen to resize which in turn caused window.resize to be called again. My other version caused a break because when the instruction section resizes off-screen in design mode, the blockly blocks disappear. When switching back to code mode, the window.resize in actions.changeInterfaceMode was required in order to make the blocks show up again.

In both cases, however, we are calling window.resize far too often and are changing the size of elements on the screen when we don't need to. This new version removes the extraneous calls to window.resize and, as a side-effect, fixes a long-standing bug where the instruction window would resize when design mode rendered over it. Now, the instruction window resizes only when we want it to rather than at a response to a blockly resize command.

[epeach]

^ Awesome simplification! Thanks for the explanation.

[epeach]

LGTM