New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spritelab Fix: toolbox displays on top of block layout when switching out of the costume tab #30233

Merged

jmkulwik merged 1 commit into staging from sprite-lab-toolbox

Aug 13, 2019

Contributor

jmkulwik commented Aug 9, 2019 •

edited

Loading

Reintroduces the change made here:
#28294

This time, we are not expecting any breaks due to the fix applied to the instruction space in this PR: #30196

Bug: https://codedotorg.atlassian.net/browse/STAR-587

Old:

New:

Couple more notes on the issue this PR fixes

Slack discussion capturing the full issue with explanation of fixes both to the instruction space and to the costume tab: https://codedotorg.slack.com/archives/C1B3PNDL7/p1565036149117300
Old PRs that attempted to fix this issue: (first) Spritelab Fix: toolbox displays on top of block layout when switching out of the costume tab #28294, (first revert) Revert "Merge pull request #28294 from code-dot-org/fix-blockly-glitchy-rendering" #28361, (second) Fixed toolbox overlay issue in spritelab. #28384, (second revert) Revert "Merge pull request #28384 from code-dot-org/fix-resize-events" #28485


          Spritelab Fix: toolbox displays on top of block layout when switching…

436055b

… out of the costume tab

jmkulwik added the star-labs label

ajpal approved these changes

View reviewed changes

jmkulwik merged commit 24ad2c7 into staging

jmkulwik deleted the sprite-lab-toolbox branch

September 13, 2019 23:59

jmkulwik mentioned this pull request

Fixed the android overflow bug. #34502

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment