Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levelbuilder Level Page Clean Up: Game Lab, Sprite Lab, and Dance #29121

Merged
merged 2 commits into from Jun 14, 2019

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Jun 14, 2019

Right now Dance Levels are a subset of Sprite Lab Levels which are a subset of Game Lab Levels. This makes game lab, sprite lab and dance all have their own separate editor files with the settings they each need instead of needing to know the weird hierarchy of these in order to know which things will show up on the page.

It also moves many things out into their own partials so we can use them on other level types in further clean up.

Finally, it starts moving everything into collapsed areas so that the page is easier to scroll through to find what you are looking for.

Game Lab Specific Area

Screen Shot 2019-06-14 at 12 32 46 PM

Sprite Lab Specific Area

Screen Shot 2019-06-14 at 12 29 26 PM

Dance Lab Specific Area

Screen Shot 2019-06-14 at 12 32 36 PM

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Dani! I like that this is cleaning up the code as well as the UI, and I love the approach of extracting components which are then shared between level types.

Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dmcavoy dmcavoy merged commit 3bab545 into staging Jun 14, 2019
@dmcavoy dmcavoy deleted the levelbuilder-update-part-1 branch June 14, 2019 17:57
islemaster added a commit that referenced this pull request Jun 17, 2019
…te-part-1"

This reverts commit 3bab545, reversing
changes made to 6d3eb57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants