Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk-Revert: Level edit page cleanup #29164

Merged
merged 7 commits into from Jun 17, 2019
Merged

Conversation

islemaster
Copy link
Contributor

@islemaster islemaster commented Jun 17, 2019

We got some feedback on the recent level edit page changes that we need to do a little more usability work before we ship this to our level builders. In particular:

Reverts:

Note: When we are ready for our next revision on this work, we should be able to revert this one PR, and continue forward from there.

…te-part-6"

This reverts commit 3a1e5dc, reversing
changes made to b047500.
…te-part-6"

This reverts commit b047500, reversing
changes made to 08eab5d.
…te-part-5"

This reverts commit 6dafc17, reversing
changes made to eb018a9.
…te-part-4"

This reverts commit 7ebf746, reversing
changes made to 4ab3040.
…te-part-3"

This reverts commit 4ab3040, reversing
changes made to 3a476ff.
…te-part-2"

This reverts commit e716d87, reversing
changes made to 92e812a.
…te-part-1"

This reverts commit 3bab545, reversing
changes made to 6d3eb57.
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Whenever we un-revert this, I'll have a follow-up task to extract some js from haml here: #29133 (comment)

@Erin007 Erin007 merged commit 87f04e5 into staging Jun 17, 2019
@Erin007 Erin007 deleted the revert-level-edit-page-cleanup branch June 17, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants