Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (but not entirely fix) another pathway to multiple account creation #29272

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jun 20, 2019

Specifically, https://app.honeybadger.io/projects/3240/faults/51067761

By only allowing the form to be submitted once per page load, we hope to
prevent the sending of multiple requests to the "create" endpoint, which
can in rare race conditions result in multiple accounts being created.

Two things to note:

  1. It's valid to only disable and never reenable, since this form
    submits via HTML rather than JS, and so expects a page load upon
    response
  2. This does not actually fix the underlying issue, which is that a race
    condition in requests may result in multiple invalid accounts being
    created. That issue will need to be fixed as a followup work item.

…eation

Specifically, https://app.honeybadger.io/projects/3240/faults/51067761

By only allowing the form to be submitted once per page load, we hope to
prevent the sending of multiple requests to the "create" endpoint, which
can in rare race conditions result in multiple accounts being created.

Two things to note:

1. It's valid to only disable and never reenable, since this form
   submits via HTML rather than JS, and so expects a page load upon
   response
2. This does not actually fix the underlying issue, which is that a race
   condition in requests may result in multiple invalid accounts being
   created. That issue will need to be fixed as a followup work item.
@Hamms Hamms requested a review from maddiedierker June 20, 2019 22:32
@Hamms Hamms merged commit 0846e95 into staging Jun 21, 2019
@Hamms Hamms deleted the prevent-multiple-finish-create branch June 21, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants