Prevent (but not entirely fix) another pathway to multiple account creation #29272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, https://app.honeybadger.io/projects/3240/faults/51067761
By only allowing the form to be submitted once per page load, we hope to
prevent the sending of multiple requests to the "create" endpoint, which
can in rare race conditions result in multiple accounts being created.
Two things to note:
submits via HTML rather than JS, and so expects a page load upon
response
condition in requests may result in multiple invalid accounts being
created. That issue will need to be fixed as a followup work item.