Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent (but not entirely fix) another pathway to multiple account creation #29272

Merged
merged 1 commit into from Jun 21, 2019

Commits on Jun 20, 2019

  1. Prevent (but not entirely fix) another pathway to multiple account cr…

    …eation
    
    Specifically, https://app.honeybadger.io/projects/3240/faults/51067761
    
    By only allowing the form to be submitted once per page load, we hope to
    prevent the sending of multiple requests to the "create" endpoint, which
    can in rare race conditions result in multiple accounts being created.
    
    Two things to note:
    
    1. It's valid to only disable and never reenable, since this form
       submits via HTML rather than JS, and so expects a page load upon
       response
    2. This does not actually fix the underlying issue, which is that a race
       condition in requests may result in multiple invalid accounts being
       created. That issue will need to be fixed as a followup work item.
    Hamms committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    eacd357 View commit details
    Browse the repository at this point in the history