Revert "Revert "Join section vulnerability""

[maddiedierker]

Reverts #30446, which reverted #30397 because it was raising this Honeybadger error for signed out users.

Solution

View filtered commits with new changes.

After #30397, when a signed out user visited /join/:section_code, they received a 500 error. Now the flow is fixed and works as follows:

1. Signed out user visits /join/:section_code
2. User is prompted to create an account or sign in to an existing account
3. If they create an account, they are automatically created as a student user and added to the section. If they sign in to an existing account, they are redirected back to /join/:section_code to finish the process of joining the section.

Note: This flow only applies to users in email section types because all other section types (word, picture, OAuth) disallow users adding themselves to a section.

Video of the above flow for signed out users:

[codecov-io]

Codecov Report

Merging #30458 into staging will increase coverage by 3.55%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           staging   #30458      +/-   ##
===========================================
+ Coverage    73.21%   76.77%   +3.55%     
===========================================
  Files         2054      679    -1375     
  Lines       112851    27777   -85074     
  Branches      3484        0    -3484     
===========================================
- Hits         82629    21326   -61303     
+ Misses       26967     6451   -20516     
+ Partials      3255        0    -3255

Flag	Coverage Δ
#integration	?
#storybook	?
#unit	?

Impacted Files	Coverage Δ
dashboard/app/controllers/followers_controller.rb	96.96% <100%> (-0.09%)	⬇️
apps/src/applab/AppLabView.jsx
.../src/lib/ui/accounts/ChangeUserTypeModal.story.jsx
apps/src/applab/GoogleChart.js
...s/src/lib/ui/accounts/manageLinkedAccountsRedux.js
apps/src/lib/ui/accounts/DeleteAccountHelpers.jsx
...c/applab/designElements/ColorPickerPropertyRow.jsx
...mplates/teacherDashboard/SelectSectionDropdown.jsx
...ps/src/templates/instructions/InputOutputTable.jsx
apps/src/templates/teacherDashboard/statsRedux.js
... and 1366 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7abb2...2e67267. Read the comment docs.

[davidsbailey]

Nice tests, and thank you for the link to the filtered commits! shift clicking commits in github is like