Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where params[:section_code] is empty #30571

Merged
merged 1 commit into from Sep 3, 2019

Conversation

maddiedierker
Copy link
Contributor

Follow-up to #30458, as it was causing this Honeybadger error for signed in users when submitting the "join section" form with an empty section code.

More detailed repro:

  1. Sign in (as any user type)
  2. Visit studio.code.org/join
  3. Submit the form by clicking "Go". Do not enter a section code.

EXPECTED: "Join section" form is re-rendered
ACTUAL: A 500 error "sad bee" page was displayed.

Video of fixed/expected flow:
out

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #30571 into staging will increase coverage by 3.59%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging   #30571      +/-   ##
===========================================
+ Coverage    73.21%   76.81%   +3.59%     
===========================================
  Files         2058      680    -1378     
  Lines       112988    27798   -85190     
  Branches      3495        0    -3495     
===========================================
- Hits         82723    21352   -61371     
+ Misses       27003     6446   -20557     
+ Partials      3262        0    -3262
Flag Coverage Δ
#integration ?
#storybook ?
#unit ?
Impacted Files Coverage Δ
dashboard/app/controllers/followers_controller.rb 98.46% <100%> (+1.44%) ⬆️
dashboard/app/models/ability.rb 100% <0%> (ø) ⬆️
apps/src/applab/AppLabView.jsx
.../src/lib/ui/accounts/ChangeUserTypeModal.story.jsx
apps/src/applab/GoogleChart.js
...s/src/lib/ui/accounts/manageLinkedAccountsRedux.js
apps/src/lib/ui/accounts/DeleteAccountHelpers.jsx
...c/applab/designElements/ColorPickerPropertyRow.jsx
...mplates/teacherDashboard/SelectSectionDropdown.jsx
...ps/src/templates/instructions/InputOutputTable.jsx
... and 1371 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1097b55...f2233df. Read the comment docs.

@maddiedierker maddiedierker merged commit ddfbaa1 into staging Sep 3, 2019
@maddiedierker maddiedierker deleted the join-section-fix branch September 3, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants