Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Viz] Implement Scatter Plot Chart type #31437

Merged
merged 9 commits into from
Nov 4, 2019
Merged

[Data Viz] Implement Scatter Plot Chart type #31437

merged 9 commits into from
Nov 4, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Oct 23, 2019

Description

Implements the scatter plot view:
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from islemaster October 23, 2019 21:30
islemaster
islemaster reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test?

@ajpal ajpal changed the base branch from oct22-hist to staging October 29, 2019 18:05
jmkulwik
jmkulwik approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

islemaster
islemaster suggested changes Oct 31, 2019
View reviewed changes
apps/test/unit/storage/dataBrowser/DataVisualizerTest.js Outdated
document.body.appendChild(chartArea);
});

afterEach(() => spy.restore());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this test to clean up the DOM.

islemaster
islemaster approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ajpal ajpal merged commit 826e3a3 into staging Nov 4, 2019
@ajpal ajpal deleted the oct23-sp-ct branch November 4, 2019 18:32
This was referenced Nov 4, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajpal @islemaster @jmkulwik