Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[Data Viz] Implement Scatter Plot Chart type"" #31666

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Nov 4, 2019

I think the issue here was that the most recent green Drone run for #31437 did not include the changes from #31631, but #31631 was merged first, so then when I merged #31437 this morning, the unit test broke. cc @Erin007

Reverts #31664

@ajpal ajpal added the star-labs label Nov 4, 2019
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajpal ajpal merged commit fe3d634 into staging Nov 5, 2019
@ajpal ajpal deleted the revert-31664-revert-31437-oct23-sp-ct branch November 5, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants