Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n sync HOC 10/29 #31539

Merged
merged 77 commits into from
Oct 29, 2019
Merged

I18n sync HOC 10/29 #31539

merged 77 commits into from
Oct 29, 2019

Conversation

deploy-code-org
Copy link
Contributor

@deploy-code-org deploy-code-org commented Oct 29, 2019

Note that this PR comes with a couple batches of expected changes, as a result of #31367

First, we expect to see all YAML headers other than title removed from the source files we upload to crowdin: 94c20d4#diff-f78c6db8b219013ad72936506b454482L3

Second, we expect to see the syntax of a number of markdown hr tags change: 51d5f64#diff-743e03f47a0a6de50922194b2b421447L13-R13

Finally, we expect to see a bunch of YAML header information removed from the translation files: 51d5f64#diff-9a1bbe37cc8ba1d9f383dea9ba3f86fdL6-L19

@Hamms Hamms requested a review from a team October 29, 2019 00:12
@Hamms Hamms added the i18n label Oct 29, 2019
@Hamms Hamms self-assigned this Oct 29, 2019
Copy link
Contributor

@nkiruka nkiruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hamms Hamms merged commit a301e59 into staging Oct 29, 2019
@Hamms Hamms deleted the i18n-sync-hoc-10-29 branch October 29, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants