Add basic ML HoC UI test [ci skip] #32114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uponthesun
changed the title
| step_list = [] | ||
| times.to_i.times do | ||
| step_list.push("Then I click selector \"#{selector}\" once I see it") | ||
| step_list.push("And I wait for 1 seconds") |
There was a problem hiding this comment.
i just realized that we can actually decrease this sleep to 0.5s (or 0.75s) because the training screen is set to have fish moving at 0.5s (link - constants.defaultMoveTime is 1s)
There was a problem hiding this comment.
I'll leave it as is for now, not sure if it would become more flaky if the framerate drops and there's not enough margin for error.
maddiedierker
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.