Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic ML HoC UI test [ci skip] #32114

Merged
merged 4 commits into from
Nov 24, 2019
Merged

Add basic ML HoC UI test [ci skip] #32114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e69e593
Add basic ML HoC UI test
Nov 23, 2019
56138e5
Increase to 200 fish
Nov 23, 2019
a19ff26
Select correct Fish button + add skips + increase to 250 fish
Nov 23, 2019
87ce212
Click on just a few fish so tests don't take too long
Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
77 changes: 77 additions & 0 deletions dashboard/test/ui/features/ml/ml_hoc.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
Feature: Oceans ML HoC

@no_circle @no_mobile @no_safari
Scenario: Fish vs. Trash
# Training Screen
Given I am on "http://studio.code.org/s/oceans/stage/1/puzzle/2?guide=off"
And I wait until element "button:contains(Fish):eq(1)" is visible
Then I click selector "button:contains(Fish):eq(1)" 5 times
Then I click selector "button:contains(Not Fish)" 5 times
Then I click selector "button:contains(Continue)" once I see it

# Sorting Screen
Then I click selector "button:contains(Run)" once I see it
Then I click selector "button:contains(Continue)" once I see it

# Pond Screen
And I wait until element "button:contains(Continue)" is visible
And I wait for 3 seconds

@no_circle @no_mobile @no_safari
Scenario: Sea Creatures
# Initial Screen
Given I am on "http://studio.code.org/s/oceans/stage/1/puzzle/3?guide=off"
Then I click selector "button:contains(Run)" once I see it
And I wait until element "button:contains(Continue)" is visible
And I wait for 2 seconds

# Training Screen
Given I am on "http://studio.code.org/s/oceans/stage/1/puzzle/4?guide=off"
And I wait until element "button:contains(Yes)" is visible
Then I click selector "button:contains(Yes)" 5 times
Then I click selector "button:contains(No)" 5 times
Then I click selector "button:contains(Continue)" once I see it

# Sorting Screen
Then I click selector "button:contains(Run)" once I see it
Then I click selector "button:contains(Continue)" once I see it

# Pond Screen
And I wait until element "button:contains(Continue)" is visible
And I wait for 3 seconds

@no_circle @no_mobile @no_safari
Scenario: Short Word List
# Training Screen
Given I am on "http://studio.code.org/s/oceans/stage/1/puzzle/6?guide=off"
Then I click selector "button:contains(Blue)" once I see it
And I wait until element "button:contains(Blue):eq(1)" is visible
Then I click selector "button:contains(Blue):eq(1)" 5 times
Then I click selector "button:contains(Not Blue)" 5 times
Then I click selector "button:contains(Continue)" once I see it

# Sorting Screen
Then I click selector "button:contains(Run)" once I see it
Then I click selector "button:contains(Continue)" once I see it

# Pond Screen
And I wait until element "button:contains(Continue)" is visible
And I wait for 3 seconds

@no_circle @no_mobile @no_safari
Scenario: Long Word List
# Training Screen
Given I am on "http://studio.code.org/s/oceans/stage/1/puzzle/8?guide=off"
Then I click selector "button:contains(Fierce)" once I see it
And I wait until element "button:contains(Fierce):eq(1)" is visible
Then I click selector "button:contains(Fierce):eq(1)" 5 times
Then I click selector "button:contains(Not Fierce)" 5 times
Then I click selector "button:contains(Continue)" once I see it

# Sorting Screen
Then I click selector "button:contains(Run)" once I see it
Then I click selector "button:contains(Continue)" once I see it

# Pond Screen
And I wait until element "button:contains(Finish)" is visible
And I wait for 3 seconds
9 changes: 9 additions & 0 deletions dashboard/test/ui/features/step_definitions/steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,3 +1746,12 @@ def pass_time_for_user(name, amount_of_time)
And(/^one year passes for user "([^"]*)"$/) do |name|
pass_time_for_user name, 1.year.ago
end

Then /^I click selector "([^"]*)" (\d+(?:\.\d*)?) times?$/ do |selector, times|
step_list = []
times.to_i.times do
step_list.push("Then I click selector \"#{selector}\" once I see it")
step_list.push("And I wait for 1 seconds")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just realized that we can actually decrease this sleep to 0.5s (or 0.75s) because the training screen is set to have fish moving at 0.5s (link - constants.defaultMoveTime is 1s)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it as is for now, not sure if it would become more flaky if the framerate drops and there's not enough margin for error.

end
steps step_list.join("\n")
end